Add @Nullable annotations #43393
Open
Add @Nullable annotations #43393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadow-Devil
requested review from
hevayo,
sameerajayasoma,
warunalakshitha,
mohanvive and
hasithaa
as code owners
Shadow-Devil
force-pushed
the
nullable-annotations
branch
2 times, most recently
from
00b47a4 to
fb77d66
Compare
Shadow-Devil
force-pushed
the
nullable-annotations
branch
from
ca4a9bc to
56a4fcc
Compare
Shadow-Devil
force-pushed
the
nullable-annotations
branch
2 times, most recently
from
b23908e to
e2b7dc6
Compare
Shadow-Devil
force-pushed
the
nullable-annotations
branch
from
e2b7dc6 to
3eaf480
Compare
Shadow-Devil
requested review from
gimantha,
MaryamZi,
KavinduZoysa,
azinneera,
NipunaRanasinghe,
Dilhasha and
keizer619
as code owners
|
@Shadow-Devil Shall we check on the build failures in github actions? |
|
Some libraries fail because of Spotbugs errors. They are using methods that are now annotated with |
|
@gimantha required pipeline went through but some std libs will require some adjustments since they use methods that are now annotated with |
# Conflicts: # bvm/ballerina-profiler/src/main/java/module-info.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/Runtime.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/async/StrandMetadata.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/concurrent/StrandMetadata.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/creators/ValueCreator.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/utils/JsonUtils.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/BalRuntime.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/launch/LaunchUtils.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/scheduling/AsyncUtils.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/scheduling/Scheduler.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/scheduling/Strand.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/scheduling/WDChannels.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/scheduling/WorkerDataChannel.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/types/BFunctionType.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/types/BIntersectionType.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/types/BNullType.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/types/BObjectType.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/AbstractArrayValue.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/ArrayValueImpl.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/AttributeMapValueImpl.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/DecimalValue.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/ErrorValue.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/FPValue.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/FutureValue.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/MapValueImpl.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/StreamValue.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/TableValueImpl.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/TupleValueImpl.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/ValueCreator.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/XmlSequence.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/XmlValue.java # bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/transactions/TransactionResourceManager.java # bvm/ballerina-runtime/src/main/java/module-info.java # compiler/ballerina-lang/src/main/java/io/ballerina/projects/ModuleContext.java # compiler/ballerina-lang/src/main/java/io/ballerina/projects/Package.java # compiler/ballerina-lang/src/main/java/io/ballerina/projects/PackageConfig.java # compiler/ballerina-lang/src/main/java/io/ballerina/projects/PackageContext.java # compiler/ballerina-lang/src/main/java/io/ballerina/projects/PackageManifest.java # compiler/ballerina-lang/src/main/java/io/ballerina/projects/internal/ManifestBuilder.java # compiler/ballerina-lang/src/main/java/io/ballerina/projects/internal/ModuleData.java # compiler/ballerina-lang/src/main/java/io/ballerina/projects/internal/PackageData.java # compiler/ballerina-lang/src/main/java/io/ballerina/projects/internal/ProjectFiles.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmTerminatorGen.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/FrameClassGen.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/MethodGen.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/MethodGenUtils.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/model/BIRTerminator.java # langlib/lang.__internal/src/main/java/org/ballerinalang/langlib/internal/WorkerChannels.java # langlib/lang.map/src/main/java/org/ballerinalang/langlib/map/Next.java # langlib/lang.value/src/main/java/org/ballerinalang/langlib/value/FromJsonDecimalString.java # langlib/lang.value/src/main/java/org/ballerinalang/langlib/value/FromJsonFloatString.java # langlib/lang.value/src/main/java/org/ballerinalang/langlib/value/FromJsonString.java # langlib/lang.xml/src/main/java/org/ballerinalang/langlib/xml/Map.java # langlib/lang.xml/src/main/java/org/ballerinalang/langlib/xml/Next.java
# Conflicts: # language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/LSPackageLoader.java
@Shadow-Devil This might need some coordination with the relevant teams to add the annotation to their repos. Let me know if you have spare time to send the those adjustment PRs to those repos. or we can merge these changes to a separate branch till we get those repos fixed by our teams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds @nullable annotations where null values are passed as arguments or assigned to variables.
Fixes #43386
Approach
Let IntelliJ generate the @nullable annotations based on its static analysis
Samples
Remarks
Check List